Skip to content

tutorials: fix incipit tutorial - #645

Merged
bwbohl merged 11 commits into
music-encoding:mainfrom
musicEnfanthen:fix-incipit-tutorial
Jan 31, 2026
Merged

bwbohl merged 11 commits into
music-encoding:mainfrom
musicEnfanthen:fix-incipit-tutorial

Conversation

@musicEnfanthen

@musicEnfanthen musicEnfanthen commented May 20, 2024 •

Copy link
Copy Markdown
Member

This PR adds some improvements for the incipit tutorial, including those proposed in #263 by @mfeustle .

This includes :

  • simplifying the note example in step 4;
  • simplifying and improving readability of the xml:ids used in the final step;
  • improving the explanation of the attributes used in the final step;
  • improving the explanation of the referencing mechanism with xml:ids in the final step;
  • fixing a typo in the title of the incipit tutorial in the Spanish translation.

Fixes #263

@musicEnfanthen

Copy link
Copy Markdown
Member Author

@martha-thomae May I ask you to have a look at the updated Spanish translations?

@musicEnfanthen
musicEnfanthen requested a review from kepper May 21, 2024 07:27
@musicEnfanthen musicEnfanthen changed the title fix(tutorials): fix incipit tutorial tutorials: fix incipit tutorial Jul 21, 2024
@rettinghaus

Copy link
Copy Markdown
Member

@martha-thomae Could you have a look please?

@musicEnfanthen
musicEnfanthen requested review from davidrizo and martha-thomae and removed request for martha-thomae September 27, 2024 14:37
@bwbohl

bwbohl commented Jan 8, 2025

Copy link
Copy Markdown
Member

pinging reviewers

@martha-thomae

Copy link
Copy Markdown
Contributor

Thanks, Benni, Klaus, and Stefan, I will look at this during this week to get it done :)

@martha-thomae martha-thomae left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor corrections for the writing in Spanish. And one extra paragraph that was missing in the Spanish translation of the English version. Thanks for all your work, @musicEnfanthen!

One small question (@musicEnfanthen, @rettinghaus, @bwbohl), do you remember how could I check from my own fork a branch of another person? Like this branch from Stefan, how can I see it on my fork to be able to run the website and see the changes locally? and also be able to actually make commits here? Thank you!

@bwbohl

bwbohl commented Jan 13, 2025 •

Copy link
Copy Markdown
Member

A few minor corrections for the writing in Spanish. And one extra paragraph that was missing in the Spanish translation of the English version. Thanks for all your work, @musicEnfanthen!

One small question (@musicEnfanthen, @rettinghaus, @bwbohl), do you remember how could I check from my own fork a branch of another person? Like this branch from Stefan, how can I see it on my fork to be able to run the website and see the changes locally? and also be able to actually make commits here? Thank you!

@martha-thomae In your above comments you can click the document with-+and- to add a suggestion for the marked lines and add your changes there. Theses then can be committed directly.

I’ll make one example for the deletion of 'del ligado' above (#645 (comment))

@musicEnfanthen

Copy link
Copy Markdown
Member Author

@martha-thomae Thanks for your review.

You can checkout any branch very easily by using gh cli tools: https://cli.github.com/ . You can then build the branch locally (see CONTRIBUTING.md for manual how to do that).

To propose changes to this PR, as @bwbohl explained, you can click on the "Files changed" tab at the top of this PR and then click on the +/- signs at the beginning of a changed line.

Co-authored-by: Benjamin W. Bohl <b.w.bohl@gmail.com>

@martha-thomae martha-thomae left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bwbohl and @musicEnfanthen for the help! I added now the actual changes :) thank you!

@martha-thomae martha-thomae left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be merged now :)

@github-project-automation github-project-automation Bot moved this to 🆕 New in ODD meetings Apr 24, 2025
@bwbohl
bwbohl merged commit cc83347 into music-encoding:main Jan 31, 2026
@github-project-automation github-project-automation Bot moved this from 🆕 New to ✅ Done in ODD meetings Jan 31, 2026
@github-project-automation github-project-automation Bot moved this from Technical issues to Done in Multilingual Tutorials Jan 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Tutorials: Suggestions on advanced/incipits tutorial

4 participants